Add "link-args=-no-pie" automatically where apropriate #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed. This implementation gets the configured linker for the target if one has been set using the same meathod as Cargo. That can be found in `scrape_build_config` and `scrape_target_config` in "src/cargo/ops/cargo_compile.rs" in Cargo. Sadly we cannot query `rustc` for its default linker for a target without nightly-only shenanigans so we have to make some assuptions. For Linux (and most everything that isn't Windows) it is fair to assume the default linker is `cc` and that `cc` is GCC based. Even if it is not, if the call to the linker to get its version information fails to does not contain "--enable-default-pie" no flags are set. Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
The splitting of RUSTFLAGS into tokens is ripped from Cargo so it should work exactly as it does. Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
|
Thanks for this, just tested on my system and it all looks good to go! Merging this now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
These patches teach Tarpaulin to add the "-no-pie" flag where allowed and needed.
This has been tested on Ubuntu 17.04 (requires the linker flag) and Ubuntu 15.04 (rejects the linker flag).