Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Remove stopped indicator #358

Closed
charlesg99 opened this issue May 13, 2019 · 1 comment · Fixed by #367
Closed

Feature request: Remove stopped indicator #358

charlesg99 opened this issue May 13, 2019 · 1 comment · Fixed by #367
Assignees
@zobo
Labels
released

Comments

@charlesg99
Copy link

charlesg99 commented May 13, 2019 •
edited
Loading

When you hit a break point and then resume the execution (F5), I think it would be best to remove the yellow arrow from the gutter and also the yellow highlight of the last executed line. This would indicate that the code is executing normally again. Currently, even if the execution was resumed, the yellow arrow and the yellow highlight stay, which is very confusing as you can never be sure if the execution was correctly resumed or not.

The same is true for the call stack view, which displays the "PAUSED ON ..." label even after resuming the execution. Basically there is no way to know if your code is running or not after resuming the execution.

Thanks!
zobo added a commit to zobo/vscode-php-debug that referenced this issue Jul 15, 2019
@zobo
Fixes stopped indicator when performing stop or continue.
1c0ff57 
When the IDE requests a continue operation (step in, out, over, continue) it expects a Response and will remove the current execution position. With XDebug/DBGp the TCP connection will not send a response until another stop condition is encountered this may take an arbitrary amount of time.
This change fixes this by doing some basic validation (is the threadId valid) and then sends a response before executing the continuation command.

Closes xdebug#358
This was referenced Jul 15, 2019
Closed
Merged
zobo added a commit to zobo/vscode-php-debug that referenced this issue Jan 2, 2021
@zobo
Fixes stopped indicator when performing stop or continue.
37124d4 
When the IDE requests a continue operation (step in, out, over, continue) it expects a Response and will remove the current execution position. With XDebug/DBGp the TCP connection will not send a response until another stop condition is encountered this may take an arbitrary amount of time.
This change fixes this by doing some basic validation (is the threadId valid) and then sends a response before executing the continuation command.

Closes xdebug#358
@zobo zobo self-assigned this Feb 2, 2021
@zobo zobo closed this as completed in #367 Feb 2, 2021
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

🎉 This issue has been resolved in version 1.14.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zobo zobo

Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@zobo @charlesg99