Fixes for var_export functions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hija! Awesome. But could you add a test case for the issues too please? cheers, |
|
The problem with doing that is that when it's running the tests, the isatty() check will make it turn the ANSI colour stuff back off again as it's not outputting to a terminal, so I'm not entirely sure how to go about setting up a test case for that. |
|
Ah, right... I see. However, there seems to be a white space issue still? Xdebug generally tends to indent everything with a tab, and then align everything with a space. Not quite sure what your patch is doing, but could you please check? |
derickr
added a commit
that referenced
this pull request
Oct 19, 2011
Fixes for var_export functions with CLI color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These two commits should fix both #735 and #733. Not looked into #734 yet - I think in that case it just uses PHP's own var_dump functions?