Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terminator conditions for unregistered operations #1167

Closed
compor opened this issue Jun 21, 2023 · 0 comments · Fixed by #1201
Closed

Fix terminator conditions for unregistered operations #1167

compor opened this issue Jun 21, 2023 · 0 comments · Fixed by #1201
Labels
core xDSL core (ir, textual format, ...)

Comments

@compor
Copy link
Collaborator

compor commented Jun 21, 2023 •
edited

Based on this discussion, unregistered operations satisfy the NoTerminator conditions and this should be implemented in a manner that is similar to the mightHaveTrait method in MLIR.
@compor compor added the core xDSL core (ir, textual format, ...) label Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
math-fehr pushed a commit that referenced this issue Jun 28, 2023
@compor
core: Fix terminator conditions for unregistered operations (#1201)
e54676e 
This PR refines terminator conditions for unregistered operations.
Namely, if we allow unregistered operations, then their terminator
conditions are implicitly fulfilled.
It also modifies `has_trait` to assume the existence of any trait for
unregistered operations.

This is modelled after the [`mayBeValidWithoutTerminator`][2] and
[`mightHaveTrait`][1] in MLIR.


Resolves #1167

[1]:
https://github.com/llvm/llvm-project/blob/268032f6f10d595bb723f6b4a21632a9f3b35be8/mlir/include/mlir/IR/OperationSupport.h#L288
[2]:
https://github.com/llvm/llvm-project/blob/268032f6f10d595bb723f6b4a21632a9f3b35be8/mlir/lib/IR/Verifier.cpp#L100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: Fix terminator conditions for unregistered operations xdslproject/xdsl
1 participant
@compor