core: Fix terminator conditions for unregistered operations #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 166 166
Lines 22855 22858 +3
Branches 3478 3479 +1
=======================================
+ Hits 20275 20278 +3
Misses 2025 2025
Partials 555 555
☔ View full report in Codecov by Sentry. |
compor
commented
Jun 27, 2023
math-fehr
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Nice!
I just pushed #1202, which should move the allow_unregistered to the MLContext. This means that if allow_unregistered is not set, then we cannot create UnregisteredOp in the first place, so we don't have to pass this argument to verify anymore.
superlopuh
approved these changes
Jun 27, 2023
compor
force-pushed
the
christos/core/term-traits-for-unregistered
branch
from
d4e7e01
to
ac2a8ee
Compare
math-fehr
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines terminator conditions for unregistered operations.
Namely, if we allow unregistered operations, then their terminator conditions are implicitly fulfilled.
It also modifies
has_traitto assume the existence of any trait for unregistered operations.This is modelled after the
mayBeValidWithoutTerminatorandmightHaveTraitin MLIR.Resolves #1167