dialects: (arith) Add custom syntax for arith.constant #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLydike
added
dialects
AntonLydike
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
AntonLydike
commented
Jun 21, 2023
| @@ -652,7 +652,7 @@ def _print_attr_string(self, attr_tuple: tuple[str, Attribute]) -> None: | |||
| self.print(f'"{attr_tuple[0]}" = ') | |||
| self.print_attribute(attr_tuple[1]) | |||
|
|
|||
| def _print_op_attributes(self, attributes: Dict[str, Attribute]) -> None: | |||
| def print_op_attributes(self, attributes: Dict[str, Attribute]) -> None: | |||
There was a problem hiding this comment.
@math-fehr I made this API public so custom ops can print the default attribute dict as well.
Will push another PR to adopt this in the rest of the codebase.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
+ Coverage 88.61% 88.66% +0.05%
==========================================
Files 158 160 +2
Lines 22180 22300 +120
Branches 3326 3345 +19
==========================================
+ Hits 19654 19773 +119
+ Misses 1990 1989 -1
- Partials 536 538 +2
☔ View full report in Codecov by Sentry. |
math-fehr
approved these changes
Jun 21, 2023
docs/database_example.ipynb
Outdated
| @@ -38,7 +38,14 @@ | |||
| "cell_type": "code", | |||
| "execution_count": 1, | |||
| "id": "7aaf5d7c", | |||
| "metadata": {}, | |||
There was a problem hiding this comment.
Can you use --ClearMetadataPreprocessor.enabled=True when you update the notebooks?
That get rid of the metadata
| @@ -652,7 +652,7 @@ def _print_attr_string(self, attr_tuple: tuple[str, Attribute]) -> None: | |||
| self.print(f'"{attr_tuple[0]}" = ') | |||
| self.print_attribute(attr_tuple[1]) | |||
|
|
|||
| def _print_op_attributes(self, attributes: Dict[str, Attribute]) -> None: | |||
| def print_op_attributes(self, attributes: Dict[str, Attribute]) -> None: | |||
webmiche
approved these changes
Jun 21, 2023
superlopuh
reviewed
Jun 21, 2023
| if isinstance(value, FloatAttr): | ||
| typ = value.type | ||
| else: | ||
| typ = value.typ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.