Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Remove print_attribute_dictionary in favour of print_op_attributes #1171

Merged
merged 5 commits into from Jun 21, 2023

Conversation

AntonLydike
Copy link
Collaborator

Stacked on top of #1170

This removes the print_attribute_dictionary method from the printer in favor of the print_op_attribute method already used by the default format.

@AntonLydike AntonLydike added the core xDSL core (ir, textual format, ...) label Jun 21, 2023
@AntonLydike AntonLydike self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01 ⚠️

Comparison is base (f86a6ea) 88.66% compared to head (720c638) 88.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   88.66%   88.66%   -0.01%     
==========================================
  Files         160      160              
  Lines       22300    22289      -11     
  Branches     3345     3342       -3     
==========================================
- Hits        19773    19762      -11     
  Misses       1989     1989              
  Partials      538      538              
Impacted Files Coverage Δ
xdsl/dialects/func.py 91.32% <0.00%> (ø)
xdsl/printer.py 96.70% <ø> (-0.06%) ⬇️
xdsl/dialects/builtin.py 83.82% <100.00%> (-0.03%) ⬇️
xdsl/dialects/print.py 91.66% <100.00%> (-0.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from anton/arith-custom-format to main June 21, 2023 13:19
@AntonLydike AntonLydike requested a review from compor as a code owner June 21, 2023 13:19
@AntonLydike AntonLydike merged commit 6df7757 into main Jun 21, 2023
12 checks passed
@AntonLydike AntonLydike deleted the anton/fix-attr-dict-printing branch June 21, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants