Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove parse_pyright_version.py and change to simple sed script #1276

Merged
merged 3 commits into from Jul 20, 2023

Conversation

AntonLydike
Copy link
Collaborator

This should be less brittle than before (and removes a python script from the project)

@AntonLydike AntonLydike added the CI Continuous Integration label Jul 14, 2023
@AntonLydike AntonLydike self-assigned this Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.45 🎉

Comparison is base (c2562b6) 89.16% compared to head (4c6d5ca) 89.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   89.16%   89.61%   +0.45%     
==========================================
  Files         181      187       +6     
  Lines       24069    24560     +491     
  Branches     3657     3691      +34     
==========================================
+ Hits        21460    22010     +550     
+ Misses       2037     1968      -69     
- Partials      572      582      +10     

see 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@AntonLydike
Copy link
Collaborator Author

@superlopuh seems like your snippet didn't work after all^^

@AntonLydike AntonLydike merged commit 4c2777b into main Jul 20, 2023
10 checks passed
@AntonLydike AntonLydike deleted the anton/ci-remove-parse-pyright-version.py branch July 20, 2023 11:46
@superlopuh
Copy link
Member

Sad times, thank you for fixing it!

@superlopuh
Copy link
Member

For the record it does work in a different repo so I'm not sure what the problem was :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants