New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: remove parse_pyright_version.py
and change to simple sed script
#1276
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 89.16% 89.61% +0.45%
==========================================
Files 181 187 +6
Lines 24069 24560 +491
Branches 3657 3691 +34
==========================================
+ Hits 21460 22010 +550
+ Misses 2037 1968 -69
- Partials 572 582 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@superlopuh seems like your snippet didn't work after all^^ |
This reverts commit 7e9f58a.
Sad times, thank you for fixing it! |
For the record it does work in a different repo so I'm not sure what the problem was :) |
This should be less brittle than before (and removes a python script from the project)