Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove parse_pyright_version.py and change to simple sed script #1276

Merged
merged 3 commits into from
Jul 20, 2023
Merged

CI: remove parse_pyright_version.py and change to simple sed script #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
046aa3d
remove parse_pyright_version.py and change to simple sed script
AntonLydike Jul 14, 2023
7e9f58a
use awk instead of sed
AntonLydike Jul 20, 2023
4c6d5ca
Revert "use awk instead of sed"
AntonLydike Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/parse_pyright_version.py
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions .github/workflows/ci-pyright-fails.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@ jobs:
- name: Install the package locally
run: pip install -e ".[extras]"
- name: retrieve pyright version
run: |
python3 .github/parse_pyright_version.py
VER=$(cat .github/pyright-version.txt)
run: | # get pyright version from requirements optional file:
VER=$(sed -n 's/^.*pyright==\s*\(\S*\).*$/\1/p' requirements-optional.txt)
AntonLydike marked this conversation as resolved.
Show resolved Hide resolved
echo "PYRIGHT_VERSION=$VER" >> $GITHUB_ENV
- name: Pyright
uses: jakebailey/pyright-action@v1
Expand Down
5 changes: 2 additions & 3 deletions requirements-optional.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ ruff==0.0.278
riscemu==2.1.0
asv<0.6
isort==5.12.0
# pyright has to be the last line and fixed with `==`. The CI parses this file
# in `.github/parse_pyright_version.py` and installs the according version for
# typechecking.
# pyright version has to be fixed with `==`. The CI parses this file
# and installs the according version for typechecking.
pyright==1.1.317