core: Implement RangeVarConstraint #2704
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## emilien/irdl-split #2704 +/- ##
======================================================
+ Coverage 89.79% 89.81% +0.01%
======================================================
Files 379 379
Lines 48104 48185 +81
Branches 7370 7382 +12
======================================================
+ Hits 43197 43278 +81
- Misses 3757 3760 +3
+ Partials 1150 1147 -3 ☔ View full report in Codecov by Sentry. |
Added docstrings, and tried to clarify the variable ones! RangeVarConstraint works just like VarConstraint, but on ranges (sequences of attributes, as opposed to single attributes) |
| index_operand = TestSSAValue(IndexType()) | ||
|
|
||
| op = ConstraintRangeVarOp.create(operands=[index_operand], result_types=[i32]) | ||
| with pytest.raises(DiagnosticException): |
There was a problem hiding this comment.
Can you match for part of the exception message?
So we are sure that we are failing because of the range constraint, not something else.
| op = ConstraintRangeVarOp.create( | ||
| operands=[test_operand], result_types=[TestType("foo")] | ||
| ) | ||
| with pytest.raises(DiagnosticException): |
There was a problem hiding this comment.
Same here with the exception message
This reverts commit 197ede8.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This is similar to VarConstraint, but constraining ranges to match instead.