CI: Build a xDSL-embedding Pyodide distribution. #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
webmiche
reviewed
Jan 12, 2023
webmiche
reviewed
Jan 12, 2023
Codecov ReportBase: 90.18% // Head: 88.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 90.18% 88.87% -1.31%
==========================================
Files 52 60 +8
Lines 7149 7595 +446
Branches 1176 1238 +62
==========================================
+ Hits 6447 6750 +303
- Misses 460 591 +131
- Partials 242 254 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
webmiche
approved these changes
Jan 12, 2023
math-fehr
approved these changes
Jan 13, 2023
This was referenced Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now builds a custom Pyodide distribution, embedding xDSL and dependencies, so we can just
import xdslin JupyterLite, as desired. It should also improve startup time.This can be previewed at papychacal.github.io/xdsl
Note you might need to clear your browser's cache for the page, especially if you get some "hash mismatch" error on importing xDSL.
The Pyodide build is cached, so it should take less than 5 minutes once cached.