Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test JupyterLite build even if not deploying. #335

Merged
merged 3 commits into from Jan 13, 2023
Merged

CI: Test JupyterLite build even if not deploying. #335

merged 3 commits into from Jan 13, 2023

Conversation

PapyChacal
Copy link
Collaborator

Following #328. This makes the CI build the JupyterLite distribution with every other test and still deploy it only on pushes to the main branch.
Otherwise, issues affecting the JupyterLite can only be found after a merge..

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 88.87% // Head: 88.87% // No change to project coverage 👍

Coverage data is based on head (259f44f) compared to base (fcc7ac4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          60       60           
  Lines        7595     7595           
  Branches     1238     1238           
=======================================
  Hits         6750     6750           
  Misses        591      591           
  Partials      254      254           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@math-fehr math-fehr merged commit ca4f926 into xdslproject:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants