This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA.
As you know...
at
stereo::compute_subpixel_disparity
,x is (
base_x
+slide_offset
+window_offset
)where {
base_x
= scaled_x_rightslide_offset
∈ [ - slide_width, + slide_width ]window_offset
∈ [ - win_size, win_size ]}
So, x ∈ [ scaled_x_right - slide_width - win_size, scaled_x_right + slide_width + win_size + 1 ).
Thus x ∈ [ scaled_x_right - slide_width - win_size, scaled_x_right + slide_width + win_size ].
That's why
is correct.
(since
assert(!(right_image_pyramid_.at(keypt_left.octave).cols <= end_x))
meansassert(end_x < right_image_pyramid_.at(keypt_left.octave).cols)
, [ini_x, end_x] must be closed interval.)