Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Added double quotes around BUILD_INTERFACE and INSTALL_INTERFACE in c… #408

Closed
wants to merge 477 commits into from
Closed

Added double quotes around BUILD_INTERFACE and INSTALL_INTERFACE in c… #408

wants to merge 477 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2020

The absence of double quotes gave the following cmake error:

CMake Error in src/openvslam/CMakeLists.txt:
  Target "openvslam" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/media/code/dev/cpp/openvslam/src/openvslam/"

  which is prefixed in the source directory.


CMake Error in src/openvslam/CMakeLists.txt:
  Target "openvslam" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/media/code/dev/cpp/openvslam/src/openvslam//usr/local/include/DBoW2"

  which is prefixed in the source directory.

shinsumicco and others added 30 commits June 24, 2019 15:17
@shinsumicco
Add SSE configuration to the CI setting
3b6c525
@shinsumicco
Merge pull request #59 from shinsumicco/refactor/orb-extractor
380876a 
Use SSE instructions for point rotation in ORB extraction
@saweer
Enable ccache to accelerate a build
2c1cb6e
@shinsumicco
Merge pull request #68 from saweer/feat/use-ccache
ac05383 
Use ccache to accelerate a build
@shinsumicco
Add a config file for Travis CI
3263d14
@shinsumicco
Add a badge to README.md
151d567
@shinsumicco
Use ccache
244f8b2
@shinsumicco
Merge pull request #69 from xdspacelab/feat/ci-on-macos
c507bf8 
Setup CI on macOS
@shinsumicco
Change the dataset
25ffbf1
@shinsumicco
Merge pull request #70 from xdspacelab/fix/change-ci-dataset
796332f 
Change the dataset for CI
@ilim0t
Make base of ROS package
819e920
@ilim0t
Add documentation for ROS Package
97fdc28
@ilim0t
Add ROS Package
d0abc06
@ilim0t
Update documentation about ROS Package
4c91ade
@ilim0t
Add publisher examples
0aa181f
@shinsumicco @ilim0t
Fix the documenation for the ROS examples
2020589
@shinsumicco @ilim0t
Fix build settings for ROS packages
291f82a
@shinsumicco @ilim0t
Use the new flag for the video propetry
3fb1060 
https://github.com/opencv/opencv/blob/3.4/modules/videoio/include/opencv2/videoio.hpp#L136
@shinsumicco
Merge pull request #72 from ilim0t/feat/ros_package
afa1310 
Add ROS Package
@shinsumicco
Modify the description of the ROS package in the overview
751afbe
@shinsumicco
Enable ccache in wercker CI
7c6c3e2
@shinsumicco
Remove "ROS support" from "Currently working on" in README
23c31cd
@shinsumicco
Merge branch 'develop'
e85a930
@shinsumicco
Merge pull request #73 from shinsumicco/fix/use-ccache-for-ci
a8b59c4 
Enable ccache in wercker CI
@shinsumicco
Update .dockerignore
c426524
@shinsumicco
Compatible with the new API of util/image_util.h
860f40e
@shinsumicco
Merge pull request #74 from shinsumicco/fix/ros-image-publisher
31eb394 
Compatible with the new API of util/image_util.h
@shinsumicco
Merge branch 'develop'
2505998
@shinsumicco
Remove unneeded commands form install instructions
38f55c9
@shinsumicco
Merge branch 'develop'
76c3955
shinsumicco and others added 20 commits June 2, 2020 23:00
@shinsumicco
Merge pull request #336 from alvinsunyixiao/socket_publisher
dd8af1c 
fix socket publisher install directory
@shinsumicco
Update Node.js version
78f449d
@shinsumicco
Add missing extension for sioclient repository URI
5af7cc3
@shinsumicco
Fix include path according to the modification of sioclient
0a8d8d5
@shinsumicco
Add a compile option in order to ignore "unused-parameter" warning
8076d62
@shinsumicco
Merge pull request #366 from shinsumicco/fix/sioclient-include
6de5fec 
Fix include path according to the modification of sioclient
Added double quotes around BUILD_INTERFACE and INSTALL_INTERFACE in c…
eeb5888 
…make.
@takanotume24
Update docker.rst
7ec7b84
@shinsumicco
Minor revision for the document
5922bcd
@shinsumicco
Merge branch 'takanotume24-patch-1'
44dfd0c
@shinsumicco
Separate the vectors to store first-order and second-order covisibili…
9ba13fc 
…ty keyframes

this fixes the re-allocation issue caused in update_local_keyframes()
@shinsumicco
Disable architecture-aware optimization in Dockerfiles
a454af4
@shinsumicco
Disable architecture-aware optimization in wercker CI
824dbef
@shinsumicco
Fix dataset URI
3d83366
@shinsumicco
Remove Slack notification in wercker CI
cd0e20f
replace Slack with Spectrum
3b8efe6
@shinsumicco
Merge pull request #426 from kensakurada/master
1aec85f 
Migrate from Slack to Spectrum
@shinsumicco
Add a badge of Spectrum at the header
cf05fa9
@shinsumicco
Add Baidu Wangpan links of the dataset in the document
5919b40
@MadnessASAP
Update Eigen source to use Gitlab
81d73ef
@shinsumicco
Copy link
Collaborator

@yevsev
Thanks!
Could you rebase your pull-request branch to the latest master one?

@ghost
Copy link
Author

ghost commented Oct 7, 2020

Sorry for my late reply!

I hope it can be merged now. If not, please let me know.

@adamjstewart
Copy link

The first commit of this PR solves #454 for me. It looks like a bad rebase is preventing this from being merged. Anything I can do to help get this merged?

@ymd-stella ymd-stella mentioned this pull request Jan 30, 2021
Closed
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet