Log4j config in xebium jar

[bvklingeren]

Please remove the log4j.properties from the src/main/resources directory for it is packaged with the final jar. This pollutes the logs of software using Xebium.

[amolenaar]

Fixed. The file was not even used.

[amolenaar]

One thing: The SeleniumDriverFixture currently has a static "BasicConfigurator.configure()" statement.

I suppose both Xebium and SUT are not executed in the same JVM?

[bvklingeren]

They sometimes are executed in the same JVM. We have some mixed tests where our Fitnesse fixtures are executing some tasks that are usually executed by a scheduler and we use Xebium to see if the results are visible.
But our software has it's own logging configuration. so I would not expect that the SeleniumDriverFixture to start up its own loggers. Maybe we should kill/enhance that feature?

[barend]

Xebium is a plugin, not a stand-alone app. It should therefore not change anything at all in the logging configuration IMO.

[amolenaar]

Agreed, but if log4j is not given some sort of configuration, you'll end up having only a

log4j:WARN No appenders could be found for logger (org.apache.http.impl.conn.SingleClientConnManager).
log4j:WARN Please initialize the log4j system properly.

message in the log output. What would be wise? Use slf4j or something? Create a fixture call to set up logging (Yuk!)?

[bvklingeren]

I would indeed migrate to slf4j in the first place so users can decide
for themselves what kind of logger they are using. Let's see how
things are if that's done.

2011/5/27 amolenaar
reply@reply.github.com:

Agreed, but if log4j is not given some sort of configuration, you'll end up having only a

   log4j:WARN No appenders could be found for logger (org.apache.http.impl.conn.SingleClientConnManager).
   log4j:WARN Please initialize the log4j system properly.

message in the log output. What would be wise? Use slf4j or something?

Reply to this email directly or view it on GitHub:
#13 (comment)

[barend]

Sticking with Log4J, you could use LogManager.exists("com.xebia...") to see if a logger is configured and run the BasicConfigurator only of there is none.

[barend]

I'd use whatever Fitnesse uses. Blend into the host environment.

bvklingeren

I would indeed migrate to slf4j

[amolenaar]

System.out?

Dunno, the driver is not using anything AFAICT.

Just checked and it works nice with slf4j and slf4j-simple.

[amolenaar]

Committed. Please try.

[bvklingeren]

thanks dude, we'll do

2011/5/27 amolenaar
reply@reply.github.com:

Committed. Please try.

Reply to this email directly or view it on GitHub:
#13 (comment)

[amolenaar]

If this works okay now we can do a release.

[bvklingeren]

Unfortunately I can't test it without a lot of hassle, but I take your
word on it that it works. Go and make the release and we'll test it in
real life (we only support release builds)

Cheers,
Boudewijn

2011/5/30 amolenaar
reply@reply.github.com:

If this works okay now we can do a release.

Reply to this email directly or view it on GitHub:
#13 (comment)

[amolenaar]

I'll close this issue, unless you still face troubles.

[bvklingeren]

Sorry for the late reply, but the configuration works correctly. Only one remark: please change the scope of the slf4j-simple.jar to test, because it's an implementation wich should be provided by the user, not Xebium.

Cheers,
Boudewijn

[amolenaar]

Done that. Check out 0.4 :)