Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code is embedded from JSON-Schema-Test-Suite but does not reproduce copyright notice as required by its license #37

Closed
basak opened this issue Sep 9, 2014 · 4 comments
Closed

Code is embedded from JSON-Schema-Test-Suite but does not reproduce copyright notice as required by its license #37

basak opened this issue Sep 9, 2014 · 4 comments

Comments

@basak
Copy link

basak commented Sep 9, 2014

See https://github.com/json-schema/JSON-Schema-Test-Suite/blob/develop/LICENSE

AIUI, you free to have copied this code, but must have also copied the license text. Please can you add the LICENSE file from there, perhaps in the json_schema_test_suite/ directory or something?
sigu-399 added a commit that referenced this issue Sep 10, 2014
@sigu-399
Added JSON Schema Test Suite license #37
b773859
@xeipuuv
Copy link
Owner

xeipuuv commented Sep 10, 2014

I see, sorry about this, this totally slipped my mind.
I just added the license to the folder you mentionned.

@xeipuuv xeipuuv closed this as completed Sep 10, 2014
@basak
Copy link
Author

basak commented Sep 10, 2014

No worries. It was clearly unintentional. I just asked so as to make it easier to manage compliance at my end.

@basak
Copy link
Author

basak commented Sep 10, 2014

...and thank you for fixing it so quickly!

@xeipuuv
Copy link
Owner

xeipuuv commented Sep 10, 2014

I understand. You're welcome, that was an easy fix :)

binary132 pushed a commit to binary132/gojsonschema that referenced this issue Jan 27, 2015
@sigu-399 @jbsolomon
Added JSON Schema Test Suite license xeipuuv#37
7721c90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@basak @xeipuuv