Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nv2a 0x97 -> 0x09fc (Unknown?) unhandled #704

Open
dracc opened this issue Feb 2, 2022 · 3 comments
Open

nv2a 0x97 -> 0x09fc (Unknown?) unhandled #704

dracc opened this issue Feb 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dracc
Copy link
Contributor

dracc commented Feb 2, 2022

Title

https://xemu.app/titles/4d53006e
https://xemu.app/titles/53430007

Bug Description

According to the debug output, 0x97 -> 0x09FC is unhandled.
In the NV20 nouveau sources, this instruction is unknown.

The parameter of the call has so far been observed as one of the following:
0x1

Expected Behavior

The NV2A instruction 0x09FC should be handled.

xemu Version

0.6.2-55-gcaf84884c4

System Information

N/A

Additional Context

No response

@dracc dracc added the bug Something isn't working label Feb 2, 2022
@Triticum0
Copy link

Triticum0 commented May 11, 2022

Also, affect rolling, 0x1
https://xemu.app/titles/53430007/#Rolling

@jackchentwkh
Copy link

NV097_SET_FLAT_SHADE_OP 0x000009FC

@abaire
Copy link
Contributor

abaire commented Jul 11, 2023

Test: abaire/nxdk_pgraph_tests@cd1bdae
HW results: https://github.com/abaire/nxdk_pgraph_tests_golden_results/wiki/Results-Shade_model

As can be seen from the HW results, this only seems to affect flat shaded untextured quads. For example:

Set to 0:
Last

Set to 1:
First

My original PR that fixed the SHADE_MODEL handling can probably be easily extended to address this, since I explicitly had to add handling to cover the "provoking vertex is first" which appears to be the state used by most titles (all of the ones that I happen to have pgraph traces for set this to 1, "first"). See #1086

Spidy123222 pushed a commit to Spidy123222/xemu that referenced this issue Jul 17, 2023
This test was marked as broken due to bug xemu-project#704 which was fixed by
aee14c7 (linux-user: Rewrite do_getdents, do_getdents64). Local
testing shows this is solid now so lets re-enable the test.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20221027183637.2772968-22-alex.bennee@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants