Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #40 (The expression of an export assignment must be...) #49

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

huben92
Copy link
Contributor

@huben92 huben92 commented Mar 31, 2020

- Comply to typescript version 2.6 and above
- Tested in typescript version 3.4, typescript above 3.4 may work but not guarantee.
- Typescript reference: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#arbitrary-expressions-are-forbidden-in-export-assignments-in-ambient-contexts
@stanleynguyen
Copy link
Contributor

Awesome! Thanks for the contrib @huben92 . Quick question, would this work without changing the declaration for sub-packages (i.e. invoices https://github.com/xendit/xendit-node/blob/master/src/invoice/invoice.d.ts). Have you tried this with your local application that's dependent on xendit-node? (You can modify the file directly inside your node_modules)

@huben92
Copy link
Contributor Author

huben92 commented Mar 31, 2020

Yes, this work without changing sub-package,
Yes, i tested on my local application inside node_modules, try to build with typescript 3.4 and it work fine.

@stanleynguyen stanleynguyen merged commit 9a4a8c1 into xendit:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The expression of an export assignment must be an identifier or qualified name in an ambient context.
2 participants