Add support for solr predicates #4
Conversation
...predicates-solr/src/main/java/eu/xenit/contentcloud/thunx/predicates/solr/SolrConverter.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class SolrUtils { | ||
|
|
||
| public static String from(ThunkExpression<Boolean> thunk/*, PathBuilder<?> entityPath*/) { |
There was a problem hiding this comment.
Does the SolrConverter not need to know for which entity we're doing a query ? The thunks/expressions use entity as a placeholder, but is only applied on a specific entity.
In the querydsl implementation, this information is captured in this PathBuilder<?>.
There was a problem hiding this comment.
No, I don't think so. From the looks of the querydsl converter you need to know the subject in order to build a "correct" predicate expression.
In solr, additional sync'ed attributes are under the control of the application actually and its there where the attributes are defined (by defining an AttributeProvider bean). So, actually, I am not even sure this solr converter should be part of the set of thunx libraries. It should probably just be code in the application, or an application library.
So euhm, should we hold off merging this ? |
|
Let's close this as it seems we both agree that this should be an application level addition. |
Add support for solr predicates