Spring boot starters for API and Gateway services #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcwarren
changed the title
paulcwarren
force-pushed
the
feature/spring-boot-starter
branch
from
8cea5f3
to
6329ca1
Compare
paulcwarren
changed the title
Spring Boot itself removed all spring.provides files in 2018 See spring-projects/spring-boot#12435 for more information
tgeens
reviewed
Dec 15, 2021
thunx-api-spring-boot-starter/src/main/resources/spring.provides
Outdated
Show resolved
Hide resolved
tgeens
reviewed
Dec 15, 2021
...arter/src/main/java/eu/xenit/contentcloud/thunx/api/autoconfigure/AbacAutoConfiguration.java
Outdated
Show resolved
Hide resolved
tgeens
approved these changes
Dec 15, 2021
tgeens
approved these changes
Jan 14, 2022
...rc/main/java/eu/xenit/contentcloud/thunx/gateway/autoconfigure/GatewayAutoConfiguration.java
Outdated
Show resolved
Hide resolved
tgeens
reviewed
Jan 18, 2022
| testImplementation platform("org.springframework.cloud:spring-cloud-dependencies:${springCloudVersion}") | ||
|
|
||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' | ||
| testImplementation 'org.assertj:assertj-core:3.21.0' |
There was a problem hiding this comment.
These versions should be managed by the spring-boot platform ?
tgeens
reviewed
Jan 18, 2022
|
|
||
| compileOnly project(':thunx-spring') | ||
| compileOnly project(':thunx-pdp-opa') | ||
| compileOnly "eu.xenit.contentcloud:opa-async-java-client:0.2.0" |
There was a problem hiding this comment.
can we externalize these versions ?
tgeens
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably, overly simple but putting it out there for discussion.