Fix AddonTask dependency coordinate lookup #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in
```
val artifact = dependency.artifacts.first()
return if (artifact != null)
"${dependency.group}:${dependency.name}:${artifact.extension}:${artifact.classifier}:${dependency.version}"
else "${dependency.group}:${dependency.name}:${dependency.version}"
```
It checks if there is an artifact in the dependency's artifacts, and returns one of two possible formats. However, the `artifact` will never be null, since `.first()` will throw an error if the collection is empty, rather than returning null. This pull request changes the `first` call into a `firstOrNull` to have the variable be null if the collection is empty, and make the method work properly.
|
Thanks for contributing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in
It checks if there is an artifact in the dependency's artifacts, and returns one of two possible formats. However, the
artifactwill never be null, since.first()will throw an error if the collection is empty, rather than returning null. This pull request changes thefirstcall into afirstOrNullto have the variable be null if the collection is empty, and make the method work properly.