Update build guide #134
Merged
Update build guide #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xihuan-citrix
commented
Nov 16, 2022
xihuan-citrix
commented
- Update README.md
- Move dependency on the project name when building
xihuan-citrix
force-pushed
the
update_build_guide
branch
2 times, most recently
from
bf086fd
to
b2fff77
Compare
xihuan-citrix
force-pushed
the
update_build_guide
branch
from
b2fff77
to
46a4dcb
Compare
DeliZhangX
reviewed
Nov 21, 2022
README.md
Outdated
| `GO111MODULE` | ||
| Set `GO111MODULE` disabled | ||
| e.g. | ||
| let's say you project directory is /home/xe-guest-utilities-7.30.0 |
DeliZhangX
reviewed
Nov 21, 2022
README.md
Outdated
| 5. Build | ||
| Go into the right directory `cd $GOPATH/src/github.com/xenserver/xe-guest-utilities` | ||
| now you can `make build` or `make`. | ||
| resulting files are in `build/`, same layout as explained below | ||
| ----------- | ||
| Type `make` or `make build` to build the xenstore and xe-daemon. |
There was a problem hiding this comment.
This line should merge with line 75
DeliZhangX
reviewed
Nov 21, 2022
README.md
Outdated
| With `GO111MODULE` enabled, go projects are no longer confined to $GOPATH, instead it use go.mod to keep track fo each package and it's version | ||
|
|
||
| e.g. | ||
| let's say you project directory is /home/xe-guest-utilities-7.30.0 |
DeliZhangX
reviewed
Nov 21, 2022
mk/xe-linux-distribution
Outdated
| fi | ||
|
|
||
| eval $(sed -rn \ | ||
| 's/^Kylin Linux Advanced Server release V([0-9][0-9]).*$/distro=kylin;major=\1;/gp;' \ |
There was a problem hiding this comment.
V([0-9][0-9]) could be V([0-9]{2})
There was a problem hiding this comment.
It's a mistake in the commit, I'v merged all of the commit into one. Thus it will not show this modification anymore. Previous one commit modify this, another commit recover this. I do this modification to test Kylin V10, it should not exist.
DeliZhangX
previously approved these changes
Nov 21, 2022
build Signed-off-by: Xihuan Yang <xihuan.yang@citrix.com>
xihuan-citrix
force-pushed
the
update_build_guide
branch
from
46a4dcb
to
d9852c4
Compare
DeliZhangX
approved these changes
Nov 21, 2022
liulinC
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.