-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm run dist always fails with TS2307: Cannot find module '@xeokit/data' #7
Comments
Hello, I tried to reproduce the problem myself. And the situation is as follows. The problem lies in the order of building the packages, in turbo you should indicate in the "dist" section, "dependsOn": ["^dist"] - this means building the dependency packages first. I managed to build the repository, but I had to perform some of the steps manually. (I manually called build math, scene, webifc, viewer first) Another thing is tsconfig, here references and paths seem unnecessary to me when we use ESM packages (ready-built packages downloaded from node_modules). Another thing is that I see that there is no lock file in the repo, from npm or yarn, you should always send such a file to the version control system, this will allow for correct and faster reconstruction of dependencies. And the last thing is I wouldn't mix package managers, if we use npm then not yarn and vice versa. Yarn also has "yarn publish" but it resolves dependencies in a completely different way than NPM, which is crucial in finding the right dependencies. |
Thanks @DhivinX, I'll fix those things. |
@xeolabs I can integrate PNPM like a package manager. I can do it this week (max next week) and maybe I can fix most of the conflicts. What do you think? |
Fixed by #12 |
Attempting to build by running
npm run dist
, the process always fails with the following message:I'm stuck on this error - If anyone can see where I've configured things wrongly that would be cool.
The text was updated successfully, but these errors were encountered: