[FIX] Fix bug where SectionPlanes are clipping DistanceMeasurements too coarsely #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SectionPlanes clipping distance measurements too coarsely.
A DistanceMeasurement is designed to become entirely invisible whenever either of its end points are clipped by a SectionPlane.
When clipping a SectionPlane, we are clipping the end points, but are also incorrectly clipping the intermediate points that are used when showing the X,Y,Z axis.
For some cases, this has the undesirable effect of causing DistanceMeasurements to be clipped when a SectionPlane is actually far away from the end points.
Screencast.from.01.04.2024.18.08.42.webm