-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picking objects not work with param includeEntities #1526
Comments
Yeah this isn't even implemented within the renderer (Renderer.js), yet it's still documented on the To mask which objects get picked, the best way, before picking, would be for application code to 1.save which scene objects are not pickable The thing is, setting Therefore I think it's best to put that in the hands of the application code, which might set those pickable flags one time before doing many of picking operations, and then restore those pickable flags after all the picking is finished. Then I would remove the Does that make sense? |
What mean save scene? Iterate objecst and set pickable to |
1.Record the IDs of all objects for which Because xeokit relies on batching the objects in order to achieve performance rendering for large numbers of objects, we must enable/disable picking for the objects like this. It's a performance trade off we can't avoid. (1-2) is setting up for masked picking, (4) is cleaning up after masked picking. |
Removed |
Describe the bug
When picking objects with param
includeEntities
it not return PickResult wich must be.Got console message:
To Reproduce
Expected behavior
Same result in both picks.
Screenshots
![image](https://private-user-images.githubusercontent.com/30372087/338344840-82080754-2e55-4903-93d5-cbd10f05889e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNTIwMTQsIm5iZiI6MTcyNDA1MTcxNCwicGF0aCI6Ii8zMDM3MjA4Ny8zMzgzNDQ4NDAtODIwODA3NTQtMmU1NS00OTAzLTkzZDUtY2JkMTBmMDU4ODllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE5VDA3MTUxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM4NDY0MzcxMTg1YmJhNjZiN2JhNzcwNjk3MGE3ZDBmNmQzM2I1YmI3YjUyMjIwNTM4ZTE0MDFhZDJiZGNlZjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Jg-Y5Rb15rk7mSbBQVMneDlmjIVk8LWMYN7vlAmdoGw)
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: