Enable true validation of :actual values in kerodon.unit.test #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When test cases did not result in :error, the :actual values were not being validated due to a misplaced parenthesis! Can you spot the error? Ha ha! As part of this changeset, also fixed minor issues in expected :actual values. I suppose no one caught these as they were not actually being executed? Lastly, refactored check-report's map parameter to expect :valiator-fn key to provide a function to validate the :actual value for :error cases. Overloading the :actual key for both a function (in :error cases) and a value (otherwise) was a bit confusing.
|
Oh wow, good spot! |
glenjamin
added a commit
that referenced
this pull request
Dec 14, 2014
Enable true validation of :actual values in kerodon.unit.test
|
Thanks @glenjamin. Noticed this issue when an in-development test I wrote for PR #30 passed, when it shouldn't have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test cases did not result in :error, the :actual values were not being
validated due to a misplaced parenthesis! Can you spot the error? Ha ha!
As part of this changeset, also fixed minor issues in expected :actual values.
I suppose no one caught these as they were not actually being executed?
Lastly, refactored check-report's map parameter to expect :valiator-fn key to
provide a function to validate the :actual value for :error cases. Overloading
the :actual key for both a function (in :error cases) and a value (otherwise)
was a bit confusing.