-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Previously peridot would delete all cookies whenever the "Set-Cookie"
header received by get in merge-cookies was an empty list, which would normally be the case for code like this: (-> (session app) (request "/foo") (request "/bar")) Before these changes, cookies established by /foo would be missing for /bar. Update the tests to expire cookies instead of just dropping them on "/delete". Via Rob Browning <rlb@defaultvalue.org>
- Loading branch information
Showing
2 changed files
with
14 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2ca8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xeqi, great work. Any timeline on when you'll be publishing this fix to clojars?
c2ca8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just pushed out peridot 0.3.1 which contains this fix
c2ca8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glenjamin. Double thanks for also pushing newer release of kerodon.