fix: git zombie processes left behind after periodic image updater ru…

…ns (argoproj-labs#584)

Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov>
Signed-off-by: Francesc Arbona <francesc.arbona@global.ntt>

Dockerfile

@@ -14,7 +14,7 @@ FROM alpine:latest
 
 RUN apk update && \
     apk upgrade && \
-    apk add ca-certificates git openssh-client python3 py3-pip && \
+    apk add ca-certificates git openssh-client python3 py3-pip tini && \
     pip3 install --upgrade pip && \
     pip3 install awscli && \
     apk add gcc musl-dev python3-dev libffi-dev openssl-dev cargo make && \
@@ -30,4 +30,4 @@ COPY hack/git-ask-pass.sh /usr/local/bin/git-ask-pass.sh
 
 USER 1000
 
-ENTRYPOINT ["/usr/local/bin/argocd-image-updater"]
+ENTRYPOINT ["/sbin/tini", "--", "/usr/local/bin/argocd-image-updater"]

manifests/base/deployment/argocd-image-updater-deployment.yaml

@@ -18,8 +18,7 @@ spec:
         app.kubernetes.io/name: argocd-image-updater
     spec:
       containers:
-      - command:
-        - /usr/local/bin/argocd-image-updater
+      - args:
         - run
         image: quay.io/argoprojlabs/argocd-image-updater:latest
         imagePullPolicy: Always