Fix: git zombie processes left behind after periodic image updater runs #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov>
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
=======================================
Coverage 65.86% 65.86%
=======================================
Files 22 22
Lines 2045 2045
=======================================
Hits 1347 1347
Misses 569 569
Partials 129 129 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannfis
approved these changes
Jul 6, 2023
ks-yim
pushed a commit
to ks-yim/argocd-image-updater
that referenced
this pull request
Jul 9, 2023
…ns (argoproj-labs#584) Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov> Signed-off-by: KS. Yim <ks.yim@linecorp.com>
jwhy89
pushed a commit
to jwhy89/argocd-image-updater
that referenced
this pull request
Aug 17, 2023
…ns (argoproj-labs#584) Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov> Signed-off-by: Jarvis Yang <jarvis.yang@recurohealth.com>
xescab
pushed a commit
to xescab/argocd-image-updater
that referenced
this pull request
Sep 8, 2023
…ns (argoproj-labs#584) Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov> Signed-off-by: Francesc Arbona <francesc.arbona@global.ntt>
dlactin
pushed a commit
to dlactin/argocd-image-updater
that referenced
this pull request
May 9, 2024
…ns (argoproj-labs#584) Signed-off-by: Daniel Mavis <daniel.mavis@faa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #583, during troubleshooting and testing for that issue, I noticed that zombie git processes were building up in the running container after each periodic image updater run. The Argo CD project had a similar issue: argoproj/argo-cd#3611 and my fix uses the same solution