Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier config file #357

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

luboskmetko
Copy link
Member

Closes #351

@jakub300
Copy link
Collaborator

I have mixed feelings about adding prettier config without formatting entire project and enforcing it via eslint but it's fine.

But does it actually work, it is not valid JSON due to trailing comma?

@luboskmetko
Copy link
Member Author

I wanted to add this as a quick fix because when I was working on a JS file in generator some time ago, Prettier reformatted whole file with double quotes while we use single quotes everywhere.

@luboskmetko luboskmetko merged commit acc5c7f into xfiveco:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants