Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chisel index page (#497) #499

Merged

Conversation

edenizk
Copy link
Contributor

@edenizk edenizk commented Jun 13, 2021

Styling update for the static Chisel index page. Closes #497

@luboskmetko
Copy link
Member

@edenizk this should actually generate a list of pages like described here https://www.getchisel.co/docs/development/pages :)

I think <!-- CHISEL-PAGES-LIST --> was a placeholder used for that. Also when I run add-page command I'm getting this error. The template is created, though. Maybe that's just related to my local linking of packages, but please verify that it works without an error. Thanks

TypeError: Cannot read property '1' of null
    at Command.<anonymous> (C:\xampp\htdocs\www\test\chisel-499\node_modules\chisel-plugin-static-frontend\lib\commands\add-page.js:160:64)
    at async Promise.all (index 0)
    at async Service.run (C:\xampp\htdocs\www\test\chisel-499\node_modules\chisel-scripts\lib\Service.js:185:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

* Add styling for code elements
* Fix Chisel pages list
@edenizk
Copy link
Contributor Author

edenizk commented Jun 15, 2021

@luboskmetko, Fixing the placeholder fixed the problem thank you 🙂
I have also added styling for the code element which was missing in the preview I was working on
image

@luboskmetko luboskmetko merged commit 7219131 into xfiveco:rewrite-with-webpack Jun 17, 2021
@luboskmetko
Copy link
Member

Thanks, merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants