This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Feature: Patch ModOp #187
Open
Feature: Patch ModOp #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore Project folder of "full" Visual Studio
Type safety and not polluting the namespace.
Fix mismatched xml closing tags.
This iterates over the tree structure of a game and a patch node. Only a single patch node may be used, and all patch entries must exactly match the target structure. This ModOp does not run recursively, but is not neccessarily more space efficient since all patch children still get put on a (local) stack. This was easiest to implement, since it's easy to use the next patch sibling on a successful patch, but not on a failed patch, since it would silently fail by empty stack, not patching any following patches. Has the Unit tests from the (recursive) explicitMerge PR, just renamed to the patch ModOp.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Patch modop that is functionally identical to the explicitMerge from #174 but does nor run recursively, instead using its own stack.
This iterates over the tree structure of a game and a patch node. Only a single patch node may be used, and all patch entries must exactly match the target structure.
This ModOp does not run recursively, but is not neccessarily more space efficient since all patch children still get put on a (local) stack. This was easiest to implement, since it's easy to use the next patch sibling on a successful patch, but not on a failed patch, since it would silently fail by empty stack, not patching any following patches.
Has the Unit tests from the (recursive) explicitMerge PR, just renamed to the patch ModOp.
There's some other small changes in this PR, since the gitignore did not previously ignore the visual studio state folder (.vs), only the VSCode state. Also made an enum into an enum class for the better type safety and fixed a wrong XML closing tag in a test file.