Slight modifications to improve the use of the default_dtype parameter #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check the default_dtype to add if necessary the default endian * Modify the IOError when the metadata is absent and the default_dtype is needed * Add a test to check if an IOError is correctly raised when there is no metadata and default_dtype is None
|
Simple and perfect solution. And it is covered by tests. Thanks so much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the default_dtype to add if necessary the default endian
Modify the IOError when the metadata is absent and the default_dtype is needed
Add a test to check if an IOError is correctly raised when there is no metadata and default_dtype is None