Refactor draw module #435
Merged
Refactor draw module #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maximelucas
commented
Jul 27, 2023
maximelucas
commented
- moved utility functions in a new file
- created two utility functions for lines that were used many times in different places
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 90.97% 90.94% -0.03%
==========================================
Files 58 59 +1
Lines 4088 4076 -12
==========================================
- Hits 3719 3707 -12
Misses 369 369
☔ View full report in Codecov by Sentry. |
nwlandry
approved these changes
Jul 27, 2023
tlarock
pushed a commit
to tlarock/xgi
that referenced
this pull request
Aug 3, 2023
* refact: draw module * style: black and isort
nwlandry
added a commit
that referenced
this pull request
Aug 3, 2023
#434) * initial commit * Refactor draw module (#435) * refact: draw module * style: black and isort * fix #331 (#438) * Added the ability for users to access the optional arguments of NetworkX layout functions. (#439) * initial commit * remove order_nodes * streamline draw_multilayer function * updated defaults and docstring * added brief convert descriptions * response to review --------- Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
maximelucas
added a commit
that referenced
this pull request
Aug 4, 2023
* Added weights option to to_line_graph function. * Added tests for weighted line graph implementation. * Added s=2 test. * Added encapsulation dag code. * Added encapsulation dag tests. * Removed unnecessary combinations import. * Updated docstring. * included functions from publication (#400) * feat: added shuffle_hyperedges + tests * feat: added shuffle_hyperedges + tests * fix: filenames * fix: tests * style: black and isort * feat: added function node_swap + test * style: black and isort * fix: error from python 3.11 * attempt at listing the available statistics (#405) * attempt at listing the available statistics * fixing previous errors * Attempt at implementing suggestions by nich * second attempt at displaying the titles * another trial * titles in bold * update of the panel for dihypergraph stats * minor fixes * change the hierarchical structure * minor change * moving MultiDi-stats in the right place * adding decorators to the admonition box * moving up the decorators * up-version * feat: enforce equal aspect for circular layout #430 (#432) * feat: enforce equal aspect for circular layout #430 * changed implementation of set_aspect * Refactor draw module (#435) * refact: draw module * style: black and isort * fix #331 (#438) * Added the ability for users to access the optional arguments of NetworkX layout functions. (#439) * Added another test. * Refactored relations to subset_types. Exposed and documented empirical relations filtering function. Documentation improvements. * Update xgi/convert/encapsulation_dag.py documentation Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com> * Fix typo in xgi/convert/encapsulation_dag.py Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com> * Updates to documentation. * Minor refactor. --------- Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com> Co-authored-by: Thomas Robiglio <83019028+thomasrobiglio@users.noreply.github.com> Co-authored-by: Nicholas Landry <nicholas.landry.91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.