Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIF functionality (new) #572

Merged
merged 22 commits into from
Aug 24, 2024
Merged

HIF functionality (new) #572

merged 22 commits into from
Aug 24, 2024

Conversation

nwlandry
Copy link
Collaborator

This PR adds:

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 99.18033% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (7646f9d) to head (502f5c0).
Report is 1 commits behind head on main.

Files Patch % Lines
xgi/readwrite/hif.py 98.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   92.88%   93.15%   +0.27%     
==========================================
  Files          59       60       +1     
  Lines        4383     4498     +115     
==========================================
+ Hits         4071     4190     +119     
+ Misses        312      308       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry merged commit 296056c into main Aug 24, 2024
24 checks passed
@nwlandry nwlandry deleted the hif-functionality branch August 24, 2024 15:03
@maximelucas
Copy link
Collaborator

What's the difference between the HIF and our own format?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Aug 28, 2024

What's the difference between the HIF and our own format?

Lots of things. The HIF standard is being developed with 3 other higher-order libraries (and hopefully more in the near future) which means that this will be much more standard. Secondly, HIF has far more features than the format used in XGI-DATA (empy edges, edge-dependent node attributes, directed hypergraphs, etc.) so my hope is that we can finalize the format and then convert the files in XGI-DATA to this sometime down the road.

@maximelucas
Copy link
Collaborator

Great, sounds good, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants