Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline listening doesn't seem to actually work #11

Closed
nbastin opened this issue Jan 2, 2019 · 4 comments
Closed

Offline listening doesn't seem to actually work #11

nbastin opened this issue Jan 2, 2019 · 4 comments

Comments

@nbastin
Copy link
Contributor

nbastin commented Jan 2, 2019

The download/save functionality works as expected, and the client does recognize that the file is available on disk, but if you try to play with access to a network, it uses the network stream. If you don't have a network, it just gets stuck playing 00:00:00 / 00:00:00.

@nbastin
Copy link
Contributor Author

nbastin commented Jan 2, 2019

I'm looking into this, but filing for completeness. I do have a custom configured download directory instead of the default, although I don't know if that is related.

@xgi
Copy link
Owner

xgi commented Jan 3, 2019

I was able to reproduce this issue, and it doesn't seem to be affected by the location of the download directory. This is the same issue that occurs if the player is given a non-existant filename, so I'm imagining it's caused by the player being given the remote URL instead of the file path.

@nbastin
Copy link
Contributor Author

nbastin commented Jan 6, 2019

It is passing it the wrong value from .get_playable, although I'm still not sure why (since .downloaded is appropriately indicated as True). I also can't reproduce this on my dev system, but I can always reproduce it on my laptop where I am really trying to play them...making it even more slow and fun to debug.. :-)

@nbastin
Copy link
Contributor Author

nbastin commented Jan 6, 2019

Ah so the problem is that Primary._create_player_from_selected doesn't pass the config to Episode.get_playable. More desire for config to be global.. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants