Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20190105 offline playback #15

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Conversation

nbastin
Copy link
Contributor

@nbastin nbastin commented Jan 6, 2019

Fixes issue #11 and adds a test to prevent regression. Also cleans up test_episodes.py so that they don't permanently modify the DataFile.DEFAULT_DOWNLOADED_DIR and thus prevent testing this issue.

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #15 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   97.05%   97.11%   +0.06%     
==========================================
  Files          28       28              
  Lines        2378     2394      +16     
==========================================
+ Hits         2308     2325      +17     
+ Misses         70       69       -1
Impacted Files Coverage Δ
tests/test_perspective_primary.py 100% <100%> (ø) ⬆️
castero/perspectives/primary.py 99.43% <100%> (ø) ⬆️
tests/test_episode.py 100% <100%> (ø) ⬆️
castero/episode.py 99.04% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d613c0...21d5fac. Read the comment docs.

@xgi xgi merged commit 1795c82 into xgi:master Jan 7, 2019
@xgi
Copy link
Owner

xgi commented Jan 7, 2019

Looks good to me, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants