-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen flickers when open a file in new tab #79
Comments
This is known, but it's good to have a bug for it. The underlying problem is that opening a new tab is not sending a This might be because |
A looked into this a little, and found that repro was inconsistent (it was particularly hard to repro when I was looking closely). Also, a quick scan of the code shows that it's trying to do the right thing - if the RPC isn't set up, the scroll request goes into a pending queue. So there's something deeper going on here. |
Just realized what the bug is, here while working on something related: When we open in an existing tab, the logic that does the initial line fetch doesn't happen because it is called from the view's Not sure what the best solution is, but should be trivial. |
This fixes at least part of xi-editor#79; if we were reusing a view (as when opening a file if the frontmost view was empty) we weren't properly sending the scroll_to notification.
@lennylxx Would you like to check and see if you can still reproduce this on master? I believe it's fixed, but I had trouble reproducing consistently. |
@cmyr Build on top of 4603667 and xi-editor/xi-editor@53f4267, it can't be reproduced. |
@lennylxx great, thanks for the follow-up! |
Repro steps:
Untitled
.Or reproduced by:
Untitled
.a.txt
, this will be in a new window.b.txt
.Actual result:
Looks like the window is refreshing and there is flash/flickering every time you move the cursor.
Expected result:
No flash/flickering
The text was updated successfully, but these errors were encountered: