-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change safeURL to absLangURL in site-navbar menu for multi languages #56
Conversation
@MaxdSre Please, remove the last commit from this PR, because it's not related to the initial issue. |
As for your proposal about sitemap. I like to have an option for this in configuration. But now it could be a braking change for some users. |
Also, the first commit brakes links with non-standard schemas as it's explained in docs:
|
But in the following way we can handle it:
|
@Zebradil I have remove the last commit, and I also tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, in the end, should we change to {{ .URL | absLangURL | safeURL}}
?
The code I checked is still {{ .URL | absLangURL }}
.
Yes, we need to change it. Yesterday I saw another version. Probably, force push was done to the source branch. |
After multi-language setting is enabled, once I change to another language, and click the site navbar menu, the site url may redirects to the default language menu.
The absolute URL function you use in the file
layouts/partials/header.html
is safeURL. Changing it to function absLangURL will solve the issue.You can see the effect on my blog.