-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superlu master (post 6.0.0) breaks PETSc #101
Comments
I am not sure whether this was really caused by #98 or #99, as Doxygen seems to have a problem. From the configure.log:
and
Looks like an issue with Doxygen in the runner. @prj- Can you please do the following to help narrowing down the problem:
|
Still not OK with |
Thanks for the feedback! Disabling Doxygen triggered in issue that I fixed in the updated #102. The call to |
@gruenich and/or @xiaoyeli, this issue is still not fixed, you can look at https://gitlab.com/petsc/petsc/-/jobs/5105845302. This makes the latest SuperLU still unusable in PETSc. There is a release scheduled later this month, could you please try to fix this rather sooner than later? Why are you even looking for Doxygen in the first place if documentation is disabled? |
|
@gruenich |
Sorry to hear that you still have a bad experience using SuperLU! But it is your Doxygen binary, that is broken. I quote from the configure.log that was created from the linked build:
Please fix your CI runner to get a working Doxygen installed (or do explicitly remove the broken Doxygen). To clarify, SuperLU does not automatically build the documentation with Doxygen. But it does check for Doxygen and prepare everything for the manual command. During the check Doxygen is called, this fails miserably on your system. You disable this check by passing |
So, you think this is the proper behavior to not be able to build SuperLU, when a non-required package cannot be found or does not work correctly? |
I view Doxygen is "external" to SuperLU. So we don't have control whether the users have doxygen or have a broken doxygen. I think the default behavior is NOT to check doxygen. |
Exactly.. why can't I build SuperLU with a broken Doxygen if I don't care about the documentation? Sure, thanks to your help, I now know about the ninja flag |
@prj- if (enable_doc) By default, enable_doc==OFF Can you try the master branch now? |
Here is the corresponding PETSc pipeline: https://gitlab.com/petsc/petsc/-/pipelines/1009190500. |
@xiaoyeli You are breaking @prj- You have to install |
@gruenich, no, I don't have admin rights to that machine. Again, I do not want to fix Doxygen, because I know some other users will have broken Doxygen. I don't see how Sherry's patch will break
Do you have some metrics on the number of SuperLU users who do |
I created a patch for CMake, see https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8815. Let's see how far we get there. |
Either #99 or #98 broke configuration in PETSc, see, e.g., https://gitlab.com/petsc/petsc/-/jobs/4430894576.
@xiaoyeli @prj- I moved this to an issues of it own. Let us continue here with the discussion.
The text was updated successfully, but these errors were encountered: