Improve Fortran with CMake #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fortran code is not provided for f_p?drive, fpd?drive3d, f_5x5
Honor enable_internal_blaslib if set by the user, do not always override with xSDK's default value.
Handle XSDK_ENABLE_Fortran similar to XSDK_ENABLE_Fortran.
Both main Fortran files where part of the library. Remove use of enable_* variables
It does not serve any purpose
Use can define to build examples with ALL
|
Either this MR or #98 broke configuration in PETSc, yet again, see, e.g., https://gitlab.com/petsc/petsc/-/jobs/4430894576. That's unbelievable... |
|
@gruenich |
|
I opened an issue to track PETSc' build problem: #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of Fortran interface when building with CMake.