Remove folder permissions notices

[pdewouters]

The newly added Path class is smart enough to create the backups folder either under wp-content or under the uploads folder which will always be writable by WordPress.

The whoami command is sometimes disabled on shared hosts. This can cause unnecessary errors for users.

I don't think we should use WP_Filesystem to create folders / files as the backup functionality is mostly run without user interaction, so displaying a login form doesn't help.

wp_mkdir_p should suffice, we should probably throw an error and bubble it up to UI if it is unsuccessful though.

https://github.com/humanmade/backupwordpress/blob/master/classes/class-path.php#L211

[pdewouters]

@willmot any thoughts?

[willmot]

I agree we should remove those error messages, the advice to run chmod and chown is completely useless to most users and bad practise anyway.

However we'll still have an issue if the backups directory can't be created (which is the only time users see those above messages anyway).

I would see us using WP_Filesystem as part of some kind of setup screen or maybe from an action shown in the error message, IE it's a one time thing which the user initiates to use WP_Filesystem to create the backups folder with the correct permissions.

[willmot]

Discussed this in Slack:

We should:

• Try to create the folder in WP_CONTENT using wp_mkdir_p
• If not possible, attempt to use WP_Filesystem to create it (with user entering their details)
• If not possible (or we need a fallback and can't ask user for details) then fallback to uploads
• We'll still need notices for when the backups directory can't be created.

We'll probably want to tackle #538 at the same time

[pdewouters]

Fixes #855
Fixes #819

[pdewouters]

@willmot do you think this is a good approach?

[willmot]

@pdewouters will need to check it out locally, could you drop in some screens of the user flow.

[pdewouters]

To replicate, you'll need to chmod 000 /backups-folder but you can't do that from inside vagrant.
It will then display the FTP creds form until it gets correct credentials, then it will create the folder.

[pdewouters]

• hide everything else on page and explanation message

[willmot]

More like:

See #872 for the page heading "BackUpWordPress"

[dashaluna]

@willmot I'm adding it to the main wp-config.php file.

Can you confirm that wp-config.php is definitely the one being used (just try deleting it's contents or something). Maybe there's a wp-config.php in src.

Face palm it is indeed the src/wp-config.php file, I didn't notice it was there..

[dashaluna]

@willmot you were right, I had to edit src/wp-config.php file. I've tested the Run now functionality and updated this comment #833 (comment) with the test results.

It doesn't seem to work on VMWareFusion server at all. I've no idea why :( Can we ask someone else to test this on VMWareFusion? Or should we look at my instance of it and figure out why it's not saving backups?

[willmot]

I'm running Fusion locally and can confirm it's working fine. Do the unit tests run when using vmware for you?

[willmot]

@dashaluna I went through and retested the whole flow here and everything is working as expected. Shall we screenshare to debug your Fusion issues?

[willmot]

@sambulance @shadyvb this one just needs conflict resolving and can then be merged.

[sambulance]

Part of the merge conflict was because we removed the is_backup_possible() check from around the admin recently (#1030). I've created a segmented version of this to just check if we have access to read and write directories, and if not, show the credentials form.

[sambulance]

@shadyvb Please can you review/merge this, specifically my last commit?

[katmoody]

@sambulance is this completed?

[sambulance]

This is waiting on code review, doesn't have to be Shady.

[katmoody]

I think this is still looking for a review per Sam's last response. @willmot or @pdewouters since you were the most active in earlier parts of this one, can you give it a look when you're able and see if we're able to go forward on this with the next release or if there are any other specific tasks that need to be completed first? Thanks!

[willmot]

Yep this looks good 👍