-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove folder permissions notices #833
Conversation
@willmot any thoughts? |
I agree we should remove those error messages, the advice to run However we'll still have an issue if the backups directory can't be created (which is the only time users see those above messages anyway). I would see us using |
Discussed this in Slack: We should:
We'll probably want to tackle #538 at the same time |
# Conflicts: # classes/class-requirement.php
Also fixes duplicate notices
This allows us to get a list of possible paths for the backups folder without attempting to create them
@willmot do you think this is a good approach? |
@pdewouters will need to check it out locally, could you drop in some screens of the user flow. |
|
More like: See #872 for the page heading "BackUpWordPress" |
Face palm it is indeed the |
@willmot you were right, I had to edit It doesn't seem to work on |
I'm running Fusion locally and can confirm it's working fine. Do the unit tests run when using vmware for you? |
@dashaluna I went through and retested the whole flow here and everything is working as expected. Shall we screenshare to debug your Fusion issues? |
@sambulance @shadyvb this one just needs conflict resolving and can then be merged. |
Part of the merge conflict was because we removed the |
@shadyvb Please can you review/merge this, specifically my last commit? |
@sambulance is this completed? |
This is waiting on code review, doesn't have to be Shady. |
I think this is still looking for a review per Sam's last response. @willmot or @pdewouters since you were the most active in earlier parts of this one, can you give it a look when you're able and see if we're able to go forward on this with the next release or if there are any other specific tasks that need to be completed first? Thanks! |
Yep this looks good 👍 |
The newly added Path class is smart enough to create the backups folder either under
wp-content
or under theuploads
folder which will always be writable by WordPress.The
whoami
command is sometimes disabled on shared hosts. This can cause unnecessary errors for users.I don't think we should use
WP_Filesystem
to create folders / files as the backup functionality is mostly run without user interaction, so displaying a login form doesn't help.wp_mkdir_p
should suffice, we should probably throw an error and bubble it up to UI if it is unsuccessful though.https://github.com/humanmade/backupwordpress/blob/master/classes/class-path.php#L211