-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move towards Docker best practices #26
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8c48b50
Changes to the Docker CMS image to bring it closer to Docker best pra…
alexharrington 7eb0a89
Couple of fixes on the previous commit
alexharrington 30e1805
Fix permissions in ci mode
alexharrington 849e3fa
Move catch for MySQL not being started up
alexharrington e842e6f
Remove random password generation line - no longer used
alexharrington 392b257
Syntax error
alexharrington 8257f81
Move launcher config gen back to where it should be. Tidy entrypoint …
alexharrington 0b4c85b
Rename configuration file to .env
alexharrington db67645
Debugging. Add Apache configuration to pass variables through to PHP
alexharrington File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
shared/ | ||
launcher-local | ||
launcher-local | ||
launcher.env | ||
launcher-test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While there is nothing specifically wrong with the current methodology, it does seem unnecessary that we're writing a file, writing an identical temporary file, updating that file, and then writing over the original file. I might suggest doing what Laravel does... Set the secret key in the launcher config to a default value and then have the launcher generate a key if that value has not be changed on first run. It can then be passed by environment variable and you never have to worry about keeping the file updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One copy of the settings file is copied in for CI mode. I can't avoid doing that.
I could pass the SECRET_KEY in as a variable. The reason I'm not is that what it's set to doesn't really matter, only that it's relatively stable (ie doesn't change on every request) and that it's random. Passing it in is asking for users to set dumb defaults which reduces the quality of the nonces it's used to generate.