Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule Page - Add/Edit event forms allow to set negative values for Priority and Display Order #1294

Closed
PeterMis opened this issue Sep 13, 2017 · 0 comments
Closed

Schedule Page - Add/Edit event forms allow to set negative values for Priority and Display Order #1294

PeterMis opened this issue Sep 13, 2017 · 0 comments
Assignees
@PeterMis
Labels
bug
Milestone
1.8.3

Comments

@PeterMis
Copy link
Member

It does not seem to have a very negative impact on the scheduled event, but we should probably ensure that those values can't be set to negative value or validate it and don't let the user to save the form with such values.
@PeterMis PeterMis added the bug label Sep 13, 2017
@PeterMis PeterMis added this to the 1.8.3 milestone Sep 13, 2017
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Sep 13, 2017
@PeterMis
Validation against negative values
f01d84b 
In Priority, display order and recurrence detail
fixes xibosignage/xibo#1294
fixes xibosignage/xibo#1295
@PeterMis PeterMis self-assigned this Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMis PeterMis

Labels
bug
Projects
None yet
Milestone
1.8.3
Development

No branches or pull requests
1 participant
@PeterMis