Displays - Impossible to delete a display assigned to a dynamic displayGroup

[PeterMis]

While users can delete a display assigned to 'normal' displayGroup (ie not dynamic), when display is matching a criteria of dynamic displayGroup it cannot be deleted, user will see 'Unexpected Error, please contact support.'

When we look at the logs we will see the following:

WEB | DELETE | ERROR |   | /display/5 | SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`xibo`.`lkdisplaydg`, CONSTRAINT `lkdisplaydg_ibfk_2` FOREIGN KEY (`DisplayID`) REFERENCES `display` (`displayid`)) Exception Type: PDOException

With more details:

WEB | DELETE | DEBUG |   | /display/5 | SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`xibo`.`lkdisplaydg`, CONSTRAINT `lkdisplaydg_ibfk_2` FOREIGN KEY (`DisplayID`) REFERENCES `display` (`displayid`))#0 /var/www/cms/lib/Storage/PdoStorageService.php(209): PDOStatement->execute(Array) #1 /var/www/cms/lib/Entity/Display.php(598): Xibo\Storage\PdoStorageService->update('DELETE FROM `di...', Array) #2 /var/www/cms/lib/Controller/Display.php(999): Xibo\Entity\Display->delete() #3 [internal function]: Xibo\Controller\Display->delete('5') #4 /var/www/cms/vendor/akrabat/rka-slim-controller/RKA/Slim.php(79): call_user_func_array(Array, Array) #5 [internal function]: RKA\Slim->RKA\{closure}('5') #6 /var/www/cms/vendor/slim/slim/Slim/Route.php(468): call_user_func_array(Object(Closure), Array) #7 /var/www/cms/vendor/slim/slim/Slim/Slim.php(1357): Slim\Route->dispatch() #8 /var/www/cms/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\Slim->call() #9 /var/www/cms/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\Middleware\Flash->call() #10 /var/www/cms/lib/Middleware/Actions.php(142): Slim\Middleware\MethodOverride->call() #11 /var/www/cms/lib/Middleware/Theme.php(35): Xibo\Middleware\Actions->call() #12 /var/www/cms/lib/Middleware/WebAuthentication.php(133): Xibo\Middleware\Theme->call() #13 /var/www/cms/lib/Middleware/CsrfGuard.php(62): Xibo\Middleware\WebAuthentication->call() #14 /var/www/cms/lib/Middleware/State.php(117): Xibo\Middleware\CsrfGuard->call() #15 /var/www/cms/lib/Middleware/Storage.php(47): Xibo\Middleware\State->call() #16 /var/www/cms/lib/Middleware/Xmr.php(36): Xibo\Middleware\Storage->call() #17 /var/www/cms/vendor/slim/slim/Slim/Slim.php(1302): Xibo\Middleware\Xmr->call() #18 /var/www/cms/web/index.php(124): Slim\Slim->run() #19 {main}

The work around is simple -> rename the display so it no longer matches the dynamic group criteria, but of course users should not be forced to do that.