Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule - Saving on Edit after removing Repeats Until date is impossible #1402

Closed
PeterMis opened this issue Jan 31, 2018 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@PeterMis
Copy link
Member

Create a schedule with repeats set and provide Until date & Save
Edit the Event, on Repeats tab, remove the date in 'Until' field & try to Save

At this point we will see the following errors in log:

Expecting a date in recurrenceRange but received -0NaN--NaN--NaN -NaN:-NaN:-NaN.#0 /var/www/cms/lib/Controller/Schedule.php(1052): Xibo\Service\SanitizeService->getDate('recurrenceRange') #1 [internal function]: Xibo\Controller\Schedule->edit('5') #2 /var/www/cms/vendor/akrabat/rka-slim-controller/RKA/Slim.php(79): call_user_func_array(Array, Array) #3 [internal function]: RKA\Slim->RKA\{closure}('5') #4 /var/www/cms/vendor/slim/slim/Slim/Route.php(468): call_user_func_array(Object(Closure), Array) #5 /var/www/cms/vendor/slim/slim/Slim/Slim.php(1355): Slim\Route->dispatch() #6 /var/www/cms/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\Slim->call() #7 /var/www/cms/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\Middleware\Flash->call() #8 /var/www/cms/lib/Middleware/Actions.php(142): Slim\Middleware\MethodOverride->call() #9 /var/www/cms/lib/Middleware/Theme.php(36): Xibo\Middleware\Actions->call() #10 /var/www/cms/lib/Middleware/WebAuthentication.php(133): Xibo\Middleware\Theme->call() #11 /var/www/cms/lib/Middleware/CsrfGuard.php(62): Xibo\Middleware\WebAuthentication->call() #12 /var/www/cms/lib/Middleware/State.php(117): Xibo\Middleware\CsrfGuard->call() #13 /var/www/cms/lib/Middleware/Storage.php(47): Xibo\Middleware\State->call() #14 /var/www/cms/lib/Middleware/Xmr.php(37): Xibo\Middleware\Storage->call() #15 /var/www/cms/vendor/slim/slim/Slim/Slim.php(1300): Xibo\Middleware\Xmr->call() #16 /var/www/cms/web/index.php(124): Slim\Slim->run() #17 {main}

We would expect users to be able to remove the Until date in such scenario and save the event, as that can be done with a new event to repeat it 'forever', however on Edit when the Until field was populated, that's no longer possible.

@PeterMis PeterMis added the bug label Jan 31, 2018
@PeterMis PeterMis added this to the 1.8.6 milestone Jan 31, 2018
@dasgarner dasgarner self-assigned this Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants