Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gridRenderSort more robust so that it cant return an empty array #2311

Closed
dasgarner opened this issue Aug 14, 2020 · 0 comments
Closed

Make gridRenderSort more robust so that it cant return an empty array #2311

dasgarner opened this issue Aug 14, 2020 · 0 comments
Assignees
@dasgarner
Labels
enhancement An improvement to an existing feature
Projects
Xibo CMS
Milestone
2.3.7

Comments

@dasgarner
Copy link
Member

There are been some reports of errors with Library page returning results, which appear to be use to an empty ORDER BY clause.

The only way that can happen is if the array of sort columns is empty.

I think the only way that can happen is if gridRenderSort returns an empty array instead of null, which may well be due to request params being stripped.

Its certainly not a regular issue and likely an environment issue, but we could improve the protection there.
@dasgarner dasgarner added the enhancement An improvement to an existing feature label Aug 14, 2020
@dasgarner dasgarner added this to the 2.3.7 milestone Aug 14, 2020
@dasgarner dasgarner added this to To do in Xibo CMS via automation Aug 14, 2020
@dasgarner dasgarner self-assigned this Aug 14, 2020
@dasgarner dasgarner moved this from To do to In progress in Xibo CMS Sep 7, 2020
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Sep 7, 2020
@dasgarner
Make gridRenderSort() more robust xibosignage/xibo#2311
e218c4d
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Sep 7, 2020
@dasgarner
Make gridRenderSort() more robust xibosignage/xibo#2311
5565daa
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Sep 7, 2020
@dasgarner
Make gridRenderSort more robust for Reporting too. xibosignage/xibo#2311
c9a13c8
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Sep 7, 2020
@dasgarner
Make gridRenderSort more robust for Reporting too. xibosignage/xibo#2311
83adb44
Xibo CMS automation moved this from In progress to Done Sep 7, 2020
dasgarner added a commit to dasgarner/xibo-cms that referenced this issue Sep 17, 2020
@dasgarner
Fix issue with report data tables filtering/sorting.
a5cd785 
xibosignage/xibo#2311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasgarner dasgarner

Labels
enhancement An improvement to an existing feature
Projects
No open projects
Xibo CMS
  
Done
Milestone
2.3.7
Development

No branches or pull requests
1 participant
@dasgarner