Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base container for Cypress testing instead of own container #2386

Closed
maurofmferrao opened this issue Jan 6, 2021 · 1 comment
Closed
Assignees
Labels
enhancement An improvement to an existing feature
Milestone

Comments

@maurofmferrao
Copy link
Member

We need to remove Dockerfile.cypress and use package.json Cypress dev dependecy in Dockerfile.ci instead.

  • Remove Dockerfile.cypress
  • Set specific Cypress version in package.json
  • Update Dockerfile.ci to npm install dev and not prod
  • Update test suite to use base container's defined cypress version for testing
@maurofmferrao maurofmferrao added the enhancement An improvement to an existing feature label Jan 6, 2021
@maurofmferrao maurofmferrao added this to the 3.0.0-rc1 milestone Jan 6, 2021
@maurofmferrao maurofmferrao self-assigned this Jan 6, 2021
@dasgarner dasgarner assigned dasgarner and unassigned maurofmferrao Feb 4, 2021
@dasgarner
Copy link
Member

Turns out we can't use the base container for this, because the base container doesn't have node in it. There are two choices therefore - we install node in the base container, or we continue to use the separate cypress container, but with a named version in the dockerfile.

I think on balance it would be better to continue using the cypress container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants