Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Profile : Some config settings not encoded correctly after v4 migrations #3202

Closed
PeterMis opened this issue Oct 23, 2023 · 1 comment
Closed

Display Profile : Some config settings not encoded correctly after v4 migrations #3202

PeterMis opened this issue Oct 23, 2023 · 1 comment
Assignees
@PeterMis
Labels
bug
Milestone
4.0.5

Comments

@PeterMis
Copy link
Member

The main culprit seems to be the Player Software migration in v4, where we save the display profile config / display override config during the migration to adjust the versionMediaId - if there was one set.

When we save the config in the migration, it is possible that settings that may require json_encode, like on/off timers will not be encoded correctly.
@PeterMis PeterMis added the bug label Oct 23, 2023
@PeterMis PeterMis added this to the 4.0.5 milestone Oct 23, 2023
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Nov 1, 2023
@PeterMis
Display Profile : Fix player software migration, that incorrectly enc…
f0e6c11 
…oded some of the settings in profile config.

fixes xibosignage/xibo#3202
@ifarzana
Copy link

ifarzana commented Nov 2, 2023

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMis PeterMis

Labels
bug
Projects
None yet
Milestone
4.0.5
Development

No branches or pull requests
2 participants
@ifarzana @PeterMis