Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule: Event type change retains previous information #3334

Closed
ifarzana opened this issue Feb 2, 2024 · 1 comment · Fixed by xibosignage/xibo-cms#2382
Closed

Schedule: Event type change retains previous information #3334

ifarzana opened this issue Feb 2, 2024 · 1 comment · Fixed by xibosignage/xibo-cms#2382
Assignees
@PeterMis
Labels
bug
Milestone
4.0.8

Comments

@ifarzana
Copy link

ifarzana commented Feb 2, 2024 •
edited
Loading

See #3298

  • Editing a Campaign Event and changing the Event type to Layout/Overlay Layout keeps the selected Campaign as the ‘Layout’ for the event
  • Editing a Layout Event and changing the Event type to Campaign keeps the selected Layout as the ‘Campaign’ for the event

Overall, changing event type should be consistent and lock icon should not appear.

This needs to be fixed on V3
@ifarzana ifarzana added the bug label Feb 2, 2024
@ifarzana ifarzana added this to the 4.0.7 milestone Feb 2, 2024
@ifarzana ifarzana changed the title Schedule: Locking icon appears after changing event type Schedule: Event type change retains Campaign as Layout Feb 2, 2024
@ifarzana ifarzana changed the title Schedule: Event type change retains Campaign as Layout Schedule: Event type change retains previous information Feb 2, 2024
@dasgarner dasgarner modified the milestones: 4.0.7, 4.0.8 Feb 7, 2024
PeterMis added a commit to PeterMis/xibo-cms that referenced this issue Feb 23, 2024
@PeterMis
Schedule : Additional validation when changing event type on edit form.
ebc07f5 
Fixes xibosignage/xibo#3334
@PeterMis PeterMis mentioned this issue Feb 23, 2024
Merged
@ifarzana
Copy link
Author

Looks good.

✅ tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterMis PeterMis

Labels
bug
Projects
None yet
Milestone
4.0.8
Development

Successfully merging a pull request may close this issue.

Bugfix/4.0.8 issues PeterMis/xibo-cms
3 participants
@ifarzana @dasgarner @PeterMis